Multistream specs #15603
Multistream specs #15603
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
samsondav
force-pushed
the
MERC-6673
branch
3 times, most recently
from
f373e71 to
358a742
Compare
samsondav
force-pushed
the
MERC-6673
branch
2 times, most recently
from
00ca59b to
13192ab
Compare
| } | ||
| } | ||
|
|
||
| func (s *streamRegistry) Get(streamID StreamID) (strm Stream, exists bool) { | ||
| func (s *streamRegistry) Get(streamID StreamID) (p Pipeline, exists bool) { |
There was a problem hiding this comment.
What's the relation between job ids, stream ids, and pipeline ids? Seems like job and stream are analogous, and then 1 pipeline can have many streams (which is a specific type of job). Is that correct?
There was a problem hiding this comment.
Yeah this is a bit confusing. A job has exactly one pipeline_spec and those have two different IDs (we almost exclusively use the jobID to reference it though). stream_id is a completely different thing. So a job has one pipeline which may contain many stream IDs.
| // This is a hack to support the legacy "Quote" case. | ||
| // Future stream specs should use streamID tags instead. | ||
| switch len(finaltrrs) { | ||
| case 1: |
There was a problem hiding this comment.
Where do these case values come from? Why is case 2 skipped?
There was a problem hiding this comment.
Oh I see it's the number of results in the task run..Won't flexible schema result in a variable number of results - how would you know if it's benchmark/bid/ask vs bid/ask/marketDepth for example? Or is a taskRunResult just one stream result, and one stream result always one datapoint?
There was a problem hiding this comment.
This is only needed for when you specify streamID at the job level, which this PR takes us away from. So we need to continue supporting this for the old use-case but for new cases its not relevant since the task can be tagged with a streamID
samsondav
force-pushed
the
MERC-6673
branch
2 times, most recently
from
446fb9c to
f582bce
Compare
samsondav
force-pushed
the
MERC-6673
branch
4 times, most recently
from
dcea97e to
8b66587
Compare
|
Requires
Supports